superfly / flyctl-actions

:octocat: GitHub Action that wraps the flyctl
Apache License 2.0
261 stars 33 forks source link

Migrate to setup-flyctl style action #12

Closed btkostner closed 2 years ago

btkostner commented 2 years ago

Considering how simple this action is, we should consider migrating it to a setup- style action similar to how setup-node, setup-elixir, and a bunch of other actions work.

This would simplify how commands work, and has the added bonus that you can copy straight out of the docs. This would also mean we wouldn't be running commands in a docker container, so things like flyctl auth docker would work 👍

AlexanderNZ commented 2 years ago

This would be great! I'm currently integrating Fly into my pipeline and want to build and test my containers separate to deploying them (i.e. only deploy if certain integration tests pass)

Right now I can't do that with this action, because I need to auth docker. So instead I'll have to figure out a work around

mrkurt commented 2 years ago

This is a good idea.

@AlexanderNZ you can actually auth to our Docker repository without flyctl in the meantime:

      - name: 🔑 Fly Registry Auth
        uses: docker/login-action@v1
        with:
          registry: registry.fly.io
          username: x
          password: ${{ secrets.FLY_API_TOKEN }}

from: https://github.com/kentcdodds/kentcdodds.com/blob/main/.github/workflows/deployment.yml#L194-L199

jacobwgillespie commented 2 years ago

Hey, I have an initial implementation of this style of action at https://github.com/superfly/flyctl-actions/pull/20