Closed btkostner closed 2 years ago
This would be great! I'm currently integrating Fly into my pipeline and want to build and test my containers separate to deploying them (i.e. only deploy if certain integration tests pass)
Right now I can't do that with this action, because I need to auth docker
. So instead I'll have to figure out a work around
This is a good idea.
@AlexanderNZ you can actually auth to our Docker repository without flyctl
in the meantime:
- name: 🔑 Fly Registry Auth
uses: docker/login-action@v1
with:
registry: registry.fly.io
username: x
password: ${{ secrets.FLY_API_TOKEN }}
from: https://github.com/kentcdodds/kentcdodds.com/blob/main/.github/workflows/deployment.yml#L194-L199
Hey, I have an initial implementation of this style of action at https://github.com/superfly/flyctl-actions/pull/20
Considering how simple this action is, we should consider migrating it to a
setup-
style action similar to howsetup-node
,setup-elixir
, and a bunch of other actions work.This would simplify how commands work, and has the added bonus that you can copy straight out of the docs. This would also mean we wouldn't be running commands in a docker container, so things like
flyctl auth docker
would work 👍