search

superfly / flyctl-actions

:octocat: GitHub Action that wraps the flyctl
Apache License 2.0
260 stars 33 forks source link

Only set strategy if it's a deploy command #14

Closed kulor closed 2 years ago

kulor commented 2 years ago

Related to https://github.com/superfly/flyctl-actions/issues/13, fix for said issue.

The rationale for this change: assuming that the primary use case of this action is to invoke the deploy command, ensure that all other commands don't append flags that would have unexpected side effects (as I faced).

Also added some documentation to cover the case of using alternative commands

kulor commented 2 years ago

FYI, this is still failing, need to get Docker installed to debug.

kulor commented 2 years ago

Can confirm this now works for a mixture of commands run via Github Actions

jsierles commented 2 years ago

Thanks!