superfly / flyctl-actions

:octocat: GitHub Action that wraps the flyctl
Apache License 2.0
260 stars 33 forks source link

Fix bug making local-only impossible #15

Closed mveytsman closed 2 years ago

mveytsman commented 2 years ago

This PR is unrelated to https://github.com/superfly/flyctl-actions/pull/14 but can be applied on top of it, they address different issues.

The issue is that $* ends up giving us all the arguments a string, so you're comparing "deploy --local-only" with --local-only, and you end up running the command flyctl deploy --local-only --remote-only. This can't deploy because they cancel each-other out :)

==> Verifying app config
--> Verified app config
==> Building image
Error failed to fetch an image or build from source: docker is unavailable to build the deployment image
jsierles commented 2 years ago

Nice catch!