superfly / flyctl-actions

:octocat: GitHub Action that wraps the flyctl
Apache License 2.0
260 stars 33 forks source link

`flyctl certs list --json` not working in GitHub Action #43

Closed tomy0000000 closed 1 year ago

tomy0000000 commented 1 year ago

I deployed fly apps with GitHub Action and wrote a small script to export the environment URL for GitHub. However, the CI returns an error saying that the --json flag does not exist.

Check out the 🔗 Fetch Environment URL step here

Can confirm this works perfectly locally, just can't get it working on CI. Is there any difference between fly/flyctl and the version provided locally and in the cloud?

tomy0000000 commented 1 year ago

@jsierles sorry for bothering you, but can you take a look at this small issue? Many thanks 🙏

jsierles commented 1 year ago

Is this still happening? Can you paste the full command you're trying to run?

tomy0000000 commented 1 year ago

Is this still happening? Can you paste the full command you're trying to run?

Full command is flyctl certs list --json

You can find the error here

the weird thing is that fly certs list --json runs perfect on the local, but fails in GitHub action

jsierles commented 1 year ago

It's possible that was a regression in the version you had. Can you try again with the latest? It looks like your action is now failing because you don't have your fly auth token set.

tomy0000000 commented 1 year ago

It's possible that was a regression in the version you had. Can you try again with the latest? It looks like your action is now failing because you don't have your fly auth token set.

I just rerun with the latest master, and it says it's using version 0.1.0, which doesn't seems normal.

Can confirm the missing auth token is the cause here.

But I'm quite sure I have the FLY_API_TOKEN setup.

CleanShot 2023-05-11 at 18 09 32@2x

Most importantly, the deployment went smoothly.

Do you think anything is missing here?

jsierles commented 1 year ago

Nope, looks good! v0.1.0 is correct - it's the first new minor version. Before that, we used 0.0.x.