superfly / flyctl-actions

:octocat: GitHub Action that wraps the flyctl
Apache License 2.0
260 stars 33 forks source link

Action fails after upgrading flyctl version to 0.2.73 #61

Open sheerlox opened 1 week ago

sheerlox commented 1 week ago

The action fails without any error log (even in debug mode) since upgrading to flyctl v0.2.73:

image

Workflow file:

name: Deploy Staging

on:
  workflow_dispatch:
  workflow_run:
    workflows: ["Release"]
    types:
      - completed

jobs:
  deploy-staging:
    name: Deploy app
    runs-on: ubuntu-latest
    if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }}
    concurrency: deploy-staging-group
    steps:
      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
        with:
          fetch-depth: 0
          fetch-tags: true

      - name: Create .env file
        run: cp .env.example .env

      - name: Output app revision
        run: make get-revision

      - uses: superfly/flyctl-actions/setup-flyctl@master
        with:
          version: 0.2.73 # renovate: datasource=github-releases depName=flyctl packageName=superfly/flyctl versioning=semver

      - run: flyctl deploy --remote-only --config fly.staging.toml -e APP_REVISION="$(make get-revision)"
        env:
          FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN_STAGING }}

Downgrading to v0.72.2 solves the issue: image

sheerlox commented 1 week ago

@rubys it looks like the latest release is missing the binaries :smile: (pinging you as the release publisher)

EDIT: sorry didn't realize there was already an issue opened on flyctl: https://github.com/superfly/flyctl/issues/3681

rszalski commented 3 days ago

Ran into the same issue with v0.2.80. It doesn't seem like this has been resolved. Not sure what is the issue but I just downgraded to v0.2.72 as a workaround.

sheerlox commented 3 days ago

@rszalski that's weird, because the binaries are present on the v0.2.80 release as mentioned in the main issue (https://github.com/superfly/flyctl/issues/3681#issuecomment-2206545883).

So in theory the problem I was facing should be resolved, will try to update again.

sheerlox commented 3 days ago

Can confirm there's still an issue.

image