search

superfly / flyctl

Command line tools for fly.io services
https://fly.io
Apache License 2.0
1.4k stars 233 forks source link

build.image removed from template fly.toml #1340

Open carlsverre opened 1 year ago

carlsverre commented 1 year ago

Please only report specific issues with flyctl behavior. Anything like a support request for your application should go to https://community.fly.io. More people watch that space and can help you faster!

Describe the bug If you run fly launch --copy-config with an existing fly.toml which includes build.image, the resulting copied config file will not have build.image.

Initial fly.toml:

[build]
  image = "ghcr.io/singlestore-labs/singlestoredb-dev"

[[services]]
  internal_port = 3306
  protocol = "tcp"

  [[services.ports]]
    port = 3306

fly.toml after running fly launch --copy-config:

# fly.toml file generated for weathered-bush-6984 on 2022-10-06T15:45:39-07:00

app = "weathered-bush-6984"

[[services]]
  internal_port = 3306
  protocol = "tcp"

  [[services.ports]]
    port = 3306
jsierles commented 1 year ago

Thanks for the report. Would you be able to look at a PR for this?

carlsverre commented 1 year ago

I am going to be travelling for the next two weeks, so it would be a little while before I could take this on. However if someone can point me at approx where the change would need to go that would help me estimate the time for this fix.