This PR properly handles aborts during green machine creations and fixes the rollback bug.
The bug was being caused by the fact that greenMachines array was only being updated if an error didn't happen across all creations.
And so in cases where an error happened, the greenMachines array was empty and rollback logic couldn't see any machines to delete.
I narrowed this down by looking at the trace for the failed deployment, which showed that the rollback fn was actually called. All the tracing we have helped me narrow down my search area
Change Summary
This PR properly handles aborts during green machine creations and fixes the rollback bug.
The bug was being caused by the fact that greenMachines array was only being updated if an error didn't happen across all creations. And so in cases where an error happened, the greenMachines array was empty and rollback logic couldn't see any machines to delete.
I narrowed this down by looking at the trace for the failed deployment, which showed that the rollback fn was actually called. All the tracing we have helped me narrow down my search area
.