superfly / flyctl

Command line tools for fly.io services
https://fly.io
Apache License 2.0
1.41k stars 235 forks source link

Redwood Dockerfile uses node 16 as base but current Redwood requires Node 20 #3662

Open Roadmaster opened 3 months ago

Roadmaster commented 3 months ago

Describe the bug This was flagged by a support customer.

"Redwood required node =20.x but the base image generated by fly launch is using 16.3. Just FYI"

** Paste your fly.toml (unknown)

I checked and https://github.com/superfly/flyctl/blob/master/scanner/templates/redwood/Dockerfile hard-codes ARG BASE_IMAGE=node:16.13.0-alpine - this is tunable with --build-args BASE_IMAGE=whatever but I wonder if: