superfly / litefs

FUSE-based file system for replicating SQLite databases across a cluster of machines
Apache License 2.0
3.97k stars 95 forks source link

Config "candidate" and "advertise-url" of static lease from command line #288

Closed legionxiong closed 1 year ago

legionxiong commented 1 year ago

It would be nice if it could config candidate and advertise-url from command line for static lease. Then we do not need to update litefs.yaml config file frequently.

benbjohnson commented 1 year ago

@legionxiong What's the use case you have where you're frequently updating the primary in a static lease? Static leases are meant to have a single static primary. I'm hesitant to add a lot of command line flags.

legionxiong commented 1 year ago

@legionxiong What's the use case you have where you're frequently updating the primary in a static lease? Static leases are meant to have a single static primary. I'm hesitant to add a lot of command line flags.

It is meant to start new litefs primary and restart replicas quickly without updating each node's litefs.yaml.

benbjohnson commented 1 year ago

I'm going to close this for now as I'd like to avoid adding CLI flags where possible.