Closed codyps closed 1 year ago
@jmesmon Thank you for the repro code. It's makes it really easy to get a fix in. I ended up retrying on ECONNREFUSED
. I tested the fix manually with your repo but can you give it a quick try to make sure it's working how you're expecting it to? The PR is https://github.com/superfly/litefs/pull/368.
You can test it by just switching your Dockerfile to use the PR artifact:
COPY --from=flyio/litefs:pr-368 /usr/local/bin/litefs /usr/local/bin/litefs
@benbjohnson I have tested your PR with my app and I can no longer see that proxy error. 🎉
Thanks, @zaynetro! 🙏 I went ahead and merged and cut a new release: https://github.com/superfly/litefs/releases/tag/v0.5.2
Works for me too. Thanks.
I'm using
litefs
on fly.io. When my app has all machines stopped, and I send a GET request for/
, instead of the expected output, I receive a pageI've made an example app (based on stripping down my original one) which demonstrates this: https://github.com/jmesmon/litefs-proxy-error/commit/370bbaae84cf4b7f2dbb71e1421abe65eb087822
One can test either by deploying with the
deploy.sh
script (does some nix stuff), or by using a plainflyctl deploy --ha=false
. Setup is as simple as doing aflyctl launch
, accepting most defaults (just need the app created).After starting the app, use
flyctl machine stop ...
to stop the machine associated with it, then issue a http get. You'll get something like this:Subsequent requests succeed.
Instead, we'd expect all requests to succeed (as occurs when not using the
litefs
proxy).Some options: