superg / redumper

Low level CD dumper utility
GNU General Public License v3.0
179 stars 16 forks source link

Progress indicators based on file size #129

Open mnadareski opened 3 months ago

mnadareski commented 3 months ago

When processing discs with a small number of large files, like cabinet files for installers, it can appear to the end user that things like the skeleton and hash steps are not actually moving forward. If there were an overall indicator of progress based on total size or even a per-file indicator that progress is being made, that would be very helpful.

Unfortunately, I'm not sure how this would show up in verbose logging, though I assume it would be similar to the other progress indicators that are being done so far.

mnadareski commented 3 months ago

Some modern systems also suffer with this, especially since the files in question tend to be very large and encrypted. I'm not sure if encryption slows down any of the hashing or processing, but it's worth mentioning just in case.

Deterous commented 3 months ago

Alternatively if per-file progress indicator is not feasible/desirable, appending a "Large file, please wait" message whenever a large file is encountered would be an easier implementation to mostly solve the problem.

superg commented 3 months ago

I could do that better, for skeleton it's a matter of utilizing lzma progress callbacks, for hash could implement own progress callbacks.