search

superg / redumper

Low level CD dumper utility
GNU General Public License v3.0
216 stars 19 forks source link

Add PS3 system to info #147

Closed Deterous closed 4 months ago

Deterous commented 4 months ago

Adds PS3 as a supported system by redumper info Prints the serial and version of the disc.

PS3 [track.iso]:
  version: 01.01
  serial: BLUS-12345

It's also super easy to add "Title" for PS3 (the internal name for the game) to the metadata to be printed. I think this is worth adding, but I'll leave it out unless you agree. Available metadata: https://www.psdevwiki.com/ps3/PARAM.SFO

Fixes #93

Tested successfully on PS3 ISO files as well as by dumping PS3 discs

Deterous commented 4 months ago

On second thought, I have removed printing region for PS3 discs, as almost all PS3 discs are region-free, and many discs have internal serials that do not match their region (e.g. Asian/Korean often have BLJM/BLUS/BLES as their internal serial). Happy to re-add region if you want it there.

Deterous commented 4 months ago

I have removed PS4/PS5 and will make new PRs for those after PS3 has been addressed.

Thank you for being patient with me and showing the examples of using structs, they have made the code much cleaner. I did encounter one issue during testing, if I run trim_inplace(value), where value is a Japanese string, it threw a runtime error. Unsure why that happened, is it something to do with the implementation of trim_left_inplace() that I do not understand? I decided to just not trim the value component of the key-value pairs.

I fully expect more changes to be required before this can be merged, as this is my first major PR. Do not be hesitant to ask for trivial code changes even to fit the code style of the repo. I believe you should also have access to my branch to make any edits yourself if desired.