superg / redumper

Low level CD dumper utility
GNU General Public License v3.0
200 stars 18 forks source link

Allow use of system fmt #26

Closed Tatsh closed 1 year ago

Tatsh commented 1 year ago

Pass -DUSE_SYSTEM_FMT=ON to CMake for this.

superg commented 1 year ago

Want to understand the use case more, does this solve something for you? Current state is that is part of C++20, but it's fully implemented only in MSVC and gcc/llvm don't have it yet so I decided to temporarily add it as a git submodule.

Tatsh commented 1 year ago

On Linux distros any package maintainer will want to link with the system version of any library where possible, for consistency and security reasons.

This is just an option and maintains the prior behaviour.

superg commented 1 year ago

It's not linking anything, when you define FMT_HEADER_ONLY it's using templatized classes. I don't see a need for this when submodule implementation is always newer and is taken directly from the official github fmt repo.