search

superg / redumper

Low level CD dumper utility
GNU General Public License v3.0
200 stars 18 forks source link

Unable to refine CD dumps with recent builds #68

Closed joshstoik1 closed 1 year ago

joshstoik1 commented 1 year ago

Hi there,

As mentioned in #66 , the refine action hasn't been working for me in recent builds. It just prints

*** REFINE

*** END

and quits.

The attached log shows a standard dump, followed by refine requests from each Linux release going back to 176, which worked the way it was supposed to. The --refine-subchannel flag was used to make sure there'd be something to refine on each pass, but the issue isn't subchannel-specific.

Another way to reproduce this (without bad data) is by skipping sectors on the first pass. This log shows an incomplete dump (courtesy of an --lba-start offset), followed by refine requests without the --refine-subchannel flag. Again, the missing data isn't picked up until build 176.

If there is any other information I can provide to help you out, please let me know. Thanks!

superg commented 1 year ago

I'll check that out, will see if I can squeeze some time for this today, thanks for reporting

superg commented 1 year ago

Most likely it's an issue where I decide whether refine has something to do after dump e.g. c2 errors or asus drive etc (you can always refine manually btw)

superg commented 1 year ago

Ah wait, you haven't used --retries option. I changed that behavior recently, if there is no --retries=X argument, refine exits.

This way it gives you more control if you want to skip refine even if errors for further analysis.

joshstoik1 commented 1 year ago

Sorry @superg, I hadn't noticed that --retries became mandatory. That is exactly where I was going wrong. Thank you!