search

superg / redumper

Low level CD dumper utility
GNU General Public License v3.0
187 stars 17 forks source link

Prevent trailing spaces from appearing in the log file. #99

Closed maxz closed 8 months ago

maxz commented 8 months ago

It's not good form to have spaces appearing after the content and before the linefeed and a pet peeve of mine. My editor is set to highlight them so that I don't save anything with them.

While the changes are trivial, I hope you accept them so that I won't have to keep removing the trailing spaces myself.

I looked for all places where trailing spaces appear and serve no purpose (e. g. there won't be content following on the same line) and removed them.

spaces

superg commented 8 months ago

I'm sorry but I think this doesn't bring any value. My convention is that for strings there should be a space after each colon regardless of line end or not. This way it appears cleaner when you look into code. I also don't see any reason why would you edit the log. In redump.org scope we would want it unaltered and for personal backup use, does it matter?

maxz commented 8 months ago

Well, of course it does not matter too much. It's just something I dislike and that is seen as bad etiquette. It basically on the same level as not having a newline at the end of a file or as archiving files without a base directory, so that when you unpack the archive all files are strewn into your current directory.

I usually need to retrieve some values from the log and change the paths in the log (turning an absolute path which I use for various reasons into a relative one) because I prefer my harddrive and directory structure not to be apparent from the logs, but I also don't do any of that manually and the spaces makes no difference except for when viewing the file.

So I will just live with it.

superg commented 8 months ago

Well, of course it does not matter too much. It's just something I dislike and that is seen as bad etiquette. It basically on the same level as not having a newline at the end of a file or as archiving files without a base directory, so that when you unpack the archive all files are strewn into your current directory.

I literally disagree to everything that you mention here. You're just stating your personal preferences and "bad etiquette" is a strong statement to describe that.

Also there should be no absolute paths in the log unless you specify it on the command line, FYI: https://github.com/superg/redumper/issues/85