search

supergilbert / midilooper

midilooper
GNU General Public License v3.0
5 stars 0 forks source link

Midi Channel UI displays wrong ch number #3

Closed CarloCattano closed 3 years ago

CarloCattano commented 3 years ago

https://github.com/supergilbert/midilooper/blob/c2c080f4fc3bf6da3d80ad62588e3b84a0ccc537/src/midilooper/msq_track_editor.c#L197

Midi Ch1 = 0

Selecting midi Ch 6 on midilooper will effectively send on midi Ch 7 to the midi device. To avoid confusion would be better to make it match . Not sure if its enough renaming since maybe other parts of the code will break .

reference:

There are 16 possible MIDI channels, numbered from 0 to 15 in hexadecimal. In practice, musicians and software refer to the MIDI channels by counting them from 1 to 16, so that there is a difference of 1 when you program them in hexadecimal (channel "1" is coded "0", channel "10" is coded "9" and channel 16 is coded "F").

CarloCattano commented 3 years ago

https://github.com/supergilbert/midilooper/pull/4 My first PR ever !
:-)

supergilbert commented 3 years ago

Well done. It is merged

supergilbert commented 3 years ago

(I know that channel label does not really follow midi spec but for now, I make all indexes start at 0. I will check good labels later)