superhedgy / AttackSurfaceMapper

AttackSurfaceMapper is a tool that aims to automate the reconnaissance process.
https://AttackSurfaceMapper.com
GNU General Public License v3.0
1.3k stars 192 forks source link

Flake8 / Python standard formatting #14

Closed deadbits closed 4 years ago

deadbits commented 5 years ago

Just some friendly feedback but might be a good idea to run flake8 over this code base.

Just looking through it on Github, I'm seeing lots of little Python formatting issues throughout the code; like comma separated arguments without spaces, variables assigned with no spaces between the = sign, too many empty lines in functions, doc strings / function comments outside of the actual function, etc.

E.g.,

# sslGrabber Function
def sslGrabber(resolvedIP,port):
    cert=ssl.get_server_certificate((resolvedIP.address, port))
    x509=OpenSSL.crypto.load_certificate(OpenSSL.crypto.FILETYPE_PEM, cert)
deadbits commented 5 years ago

Sorry about the weird formatting in the code block example, I'm in my cell so getting the spacing correct is difficult

superhedgy commented 4 years ago

I have ran Flake8 rules on ASM, I will push the code online soon. Thank you @deadbits for raising this, I appreciate it!