superhero-com / superhero-chat-web

A glossy Matrix collaboration client for the web.
https://chat.superhero.com
Apache License 2.0
0 stars 0 forks source link

web: rebrand onboarding #62

Closed onvisions closed 6 months ago

onvisions commented 6 months ago

Acceptance criteria:

Figma reference link: https://www.figma.com/file/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?type=design&node-id=30337-177460&mode=design&t=CxNFquWOTkWrR7HR-0

Figma visual reference:

Image

onvisions commented 6 months ago

@michele-franchi As discussed with @ifaouibadi I created mockups for responsive design of the onboarding page. I am also suggesting a minor visual change in the banner compared to previous version:

Responsive design (640px-1920px):

Dark mode templates:

Image

Image

Image

Image

Image

Image

Image

Light mode template:

Image

Figma reference link: https://www.figma.com/file/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?type=design&node-id=30337-177460&mode=design&t=Q85RI7dxgDrMLcF9-0

Liubov-crypto commented 6 months ago

In general LGTM, but I have a question: is it ok, that buttons are placed one under one abut not in the row like in Figma design?

Image

@onvisions could you confirm it please?

onvisions commented 5 months ago

It has discrepancies with the design optimization for different resolutions suggested.

The design provided covers resolutions with screen width in the range between 640px - 1920px. The optimisation for lower resolutions with less space available is doable with CSS only (although it may require a few lines of CSS rules modified for the specific break point). The screenshot you posted belongs to the case of 750px width. The design is supposed to look like this:

2 1 6 HOME_ Static banner - Dark (750 px)

Even if not exactly pixel perfect we should at least pay attention to:

Figma Reference: https://www.figma.com/file/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?type=design&node-id=30475-184191&mode=design&t=tM6Zr7XhZxq5o7Sa-0

Liubov-crypto commented 5 months ago

@ifaouibadi please check @onvisions comments.

onvisions commented 5 months ago

@ifaouibadi @paolomolo I don't know if we have to invest much time into fixing all discrepancies and being pixel perfect because some of the branding may actually change as far as I know. However I would fix: the smashed image on the right, the button sizes and the text styling (font-size, line-height, new lines etc.), the margins between elements (between the buttons, text blocks on the left).