search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 39 forks source link

Superhero endless loop (saturates one CPU core) #1799

Closed loxs closed 9 months ago

loxs commented 1 year ago

Describe the bug Superhero seems to repeatedly go into some endless loop where it saturates one of my CPU cores. I get a process (on Macbook Pro M1) called “Brave Browser Helper (Renderer)” that uses 100-150% CPU and drains my battery. If I kill that process I get a notification from Brave saying that Superhero has been killed and an option to click there to reload it. I do that and for some time it’s fine, but after some period of normal usage, this thing happens again.

To Reproduce I don't have a clear reproduction path and I have no idea when it happens. My usage is just connecting and disconnecting to some daepp which uses the SDK (I am developing it at the moment). Haven’t even started to sign transactions yet. Sometimes I switch networks (mainnet/testnet). Granted, I do that a lot (connecting and disconnecting) as I am currently developing this part. This may have something to do with the permission Don't ask for login requests. Still not sure though, as I am experimenting with having the option on or off... and not sure that it does not happen when it's off

Expected behavior Superhero shouldn't go into this endless loop

Desktop (please complete the following information):

CedrikNikita commented 1 year ago

Hi, @loxs. Thank you for a report, I think I've seen this problem too. Was going to report it with a better investigation. For me it looked like that image

CedrikNikita commented 1 year ago

This commit might be one of the issues that is related to a problem you have raised e0505ca

loxs commented 1 year ago

This commit might be one of the issues that is related to a problem you have raised e0505ca

This doesn't seem to have improved the situation meaningfully

davidyuk commented 1 year ago

Can you check is this issue persist using https://github.com/aeternity/aepp-sdk-js/tree/develop/examples/browser/wallet-web-extension? its built version https://docs.aeternity.com/aepp-sdk-js/develop/examples/browser/wallet-web-extension.zip

loxs commented 1 year ago

I am not sure if I can reproduce my work/test setup with this. For example can I use another account? Otherwise, I played around with it a little (connected to aepp, triggered GA upgrade without signing/confirmation, etc..) and it doesn't seem to trigger the problem, but it's not at all representative.

CedrikNikita commented 9 months ago

Current version of wallet doesn't have such problems. Feel free to reopen this issue, if it will pop up again.