superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Move the account signing methods from Vuex to composable #2425

Closed olszewskimar closed 1 year ago

olszewskimar commented 1 year ago

https://aeternity-blockchain.atlassian.net/browse/SW-1378

Liubov-crypto commented 1 year ago

During my testing I've constantly got this issue in console, and I think it might be affect all errors that I listed below:

Error: pubkey cannot be null or undefined.

err1

  1. Can't send ae and Fungible tokens:
  2. Verify an amount and Max button isn't working for FT:

https://github.com/superhero-com/superhero-wallet/assets/69896204/d5f810e3-e958-43ed-a1cb-6ff8d2b44828

  1. Set name pointer: set pointer

  2. Register a name: reg

  3. Multisig creation

  4. Generate Gift card

  5. Bid on name

  6. Transactions on DEX: swap

  7. Interactions with superhero.com - I can connect my wallet but there is no popup for signing Txs and I can't perform any Transaction.

  8. For some reason I can't see my multisig vaults on both networks (I can see them on develop branch).

@peronczyk please check it.

peronczyk commented 1 year ago

@Liubov-crypto I updated the PR with some fixes. Can you please see if all problems are fixed?

Liubov-crypto commented 1 year ago

Sometimes I get an error with multisig creation when I'm using 2nd account or 3,4,5 accounts as 1st Signer (this issue isn't reproducible on dev):

Image Image

@peronczyk could you please check it?

The rest issues have been fixed.

Liubov-crypto commented 1 year ago

Now the issue with multisig creation is happening on dev too. We already have such issue in our backlog. I think we can proceed with this PR or should I recheck it again?

Liubov-crypto commented 1 year ago

I have retested and issue with multisig is reproducible again in the testnet. maybe I have to wait until backend will work properly and then recheck it again.

Image

Image

Liubov-crypto commented 1 year ago

It works with new wallets. I do confirm that the issue has been fixed.