search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

Easy way of switching between accounts and account counter #2602

Closed peronczyk closed 7 months ago

peronczyk commented 10 months ago

The goal of this task is:

  1. making it easier to switch between dozens of accounts,
  2. displaying the amount of available accounts,
  3. displaying the number of the active account.

My idea is to have a button that displays the X / Y (eg.: 6 / 23) somewhere in the dashboard. Clicking this button would open a list of accounts. This button should be visible only if user has more than 6 accounts. See following screens:

Image

Image

Future idea (not implemented within this task): We can go even further with this and change the way how we switch between regular accounts and the multisig:

Image

@paolomolo @smaroudas @onvisions

peronczyk commented 10 months ago

The demo for the counter and account selector is available here: https://feat-dashboard-account-counter-and-switcher.wallet.z52da5wt.xyz/

The demo for multisig switcher is available here: https://feat-accounts-and-vaults-view-switcher.wallet.z52da5wt.xyz/

peronczyk commented 7 months ago

I had a conversation with @onvisions regarding the final visual tweaks. All his suggestions were implemented.

This task is ready to be tested @Liubov-crypto

Liubov-crypto commented 7 months ago

LGTM.

I found one issue, but it's reproducible on dev branch too, will add it to our backlog.