superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

Deep-linking fills whole window instead of opening just the wallet #2849

Open nikita-fuchs opened 5 months ago

nikita-fuchs commented 5 months ago

How it should be:

image

How it is with the way it was recommended for Acurast to implement (deep-linking): bad deeplinking

Notice how the SH add-on is opened in the address bar. Obviously this all leads to a bad user experience. What do we need to have signing messages work with a proper behaviour users would expect?

CedrikNikita commented 4 months ago

This is happening because the tool you are using is connecting to the superhero-wallet via deeplink, but it connects to metamask via different connection. While Metamask was relying on the deeplink approach such links were also opening and filling whole window.