superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Support jwt signing #2952

Closed CedrikNikita closed 7 months ago

CedrikNikita commented 7 months ago

This PR also reduces amount of requests in one minute by 28.58%.

Requests on heavy loaded wallet in 1 minute. Before After
image image
github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 7 months ago
  1. I proposed multisig Tx, approved it by 2nd signer, but the info was not updating for the long time in my wallet:

https://github.com/superhero-com/superhero-wallet/assets/69896204/39bb52ae-0b35-4d77-b17f-7484d41ba1c3

  1. Canceling multisig tx got this error:

cancel multisg tx

  1. For some reason until I revoked my multisig Tx I was not able to send FT, also max button was not working:

max

https://github.com/superhero-com/superhero-wallet/assets/69896204/b3b80f6a-d4cb-486a-a09c-7621fa016f60

  1. minimise wallet and open it again on the latest multisig account: https://github.com/superhero-com/superhero-wallet/assets/69896204/8ac034db-e43d-4357-bc35-3f44e8ec3ffb
github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feature-support-jwt-signing.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 7 months ago

LGTM, the last issue is reproducible on dev too, will register it separately.