superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

fix: estimate gas limit for erc20 transfers #2977

Closed martinkaintas closed 6 months ago

martinkaintas commented 7 months ago

closes #2971 closes #3010

github-actions[bot] commented 7 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 7 months ago

the issue still remains:

tt ff

github-actions[bot] commented 7 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 7 months ago

In general it's working. I can send max amount all my ERC-20 tokens and ETH. I would like to check it once again when new SDK version will be applied.

github-actions[bot] commented 6 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 6 months ago

In general it's working, but could be some edge cases.

For example:

I got this issue when tried to send Link token one by one: 1- i sent 0.1 link 2 - was trying to sent max link in a while and got an issue

I think this is because the previous tx was in pending status and the balance was not updated properly after sent 1st tx:

link errr

I have question about WETH: is this total sum correct? i was sending 0.0001 WETH , but see it as 0.0002 (there is a fee paid in eth)

https://github.com/superhero-com/superhero-wallet/assets/69896204/5a45e157-c735-4470-b803-90f00d706dbf

github-actions[bot] commented 6 months ago

Deployed to fix-estimate-gas-limit-for-erc-20.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 6 months ago

The second issue has been fixed, LGTM.

For the first one I've registered a separate issue.