[WIP] feat: ETH WalletConnect dapps support - Githubissues

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.

https://wallet.superhero.com

ISC License

40 stars 38 forks source link

[WIP] feat: ETH WalletConnect dapps support #2978

Closed peronczyk closed 5 months ago

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 7 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 6 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 5 months ago

Idk, if it's an issue, but for example if I have 2 ETH accounts in my wallet I will be not able to connect my second account, only the first one. Probably this feature is not developed yet. Can't attach the video recording((

In general LGTM, I can connect wallet via wallet connect or scan the QR code. Transactions also look fine, Tx details. Regarding the swap ETH to WETH and displaying it I asked in our chat.

I've tested the pr only in testnet (tested connection in mainnet too, but without swapping). Regarding apk, I tested it with web version of uniswap, haven't installed native app on phone (not mine).

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 5 months ago

I made swap from ETH to WETH, on confirmation modals it displays with tags: App.Uniswap.org and Contract call:

when Tx will be completed and fetched I will see in Tx details this Tx as Spend Out:

eth2

is it correct?

I agree that user have to pay ETH for wrapping it to WETH as first part of Tx.

But we don't show the second part - incoming WETH to wallet balance in any way.... might be one confusion for user - WETH will be displayed on wallet balance, but incoming Tx related to this is not:

I made swap from WETH to ETH with tags on confirmation modal: App.Uniswap.org and Contract call:

weth

when Tx will be fetched I will see it with Spend Out tags and only with ETH fee amount (agree that we can't display full amount atm):

weth2

my question is: is it correct that tags are changing after fetching data?

Is it correct that approval modal is appearing within the extension not above the uniswap site?

https://github.com/superhero-com/superhero-wallet/assets/69896204/c6901edd-755a-4850-9610-387321c9a1a2

Liubov-crypto commented 5 months ago

I made swap from ETH to WETH, on confirmation modals it displays with tags: App.Uniswap.org and Contract call:

when Tx will be completed and fetched I will see in Tx details this Tx as Spend Out:

is it correct?

I agree that user have to pay ETH for wrapping it to WETH as first part of Tx.

But we don't show the second part - incoming WETH to wallet balance in any way.... might be one confusion for user - WETH will be displayed on wallet balance, but incoming Tx related to this is not:

I made swap from WETH to ETH with tags on confirmation modal: App.Uniswap.org and Contract call:

when Tx will be fetched I will see it with Spend Out tags and only with ETH fee amount (agree that we can't display full amount atm):

my question is: is it correct that tags are changing after fetching data?

Is it correct that approval modal is appearing within the extension not above the uniswap site?

2024-06-07.5.54.31.mov

As we agreed I've registered these issues separately.

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 5 months ago

Connection is working fine for me , except FF ext/web (but this is known issue with scan qr and present on dev). The rest LGTM

github-actions[bot] commented 5 months ago

Deployed to feat-eth-dapps-support.wallet.z52da5wt.xyz, artifacts