feat/airgap integration

[martinkaintas]

closes #2866

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[Liubov-crypto]

1. I've created multisig vault using airgap vault account as a first signer, after that I proposed a Tx from this superhero vault. I got an confirmation popup that Tx was successful but at the end no pending Tx in my sh wallet. Also I see that on the final step confirmation sign modal is missing if I compare it with multisig vault created from regular ae accounts.

for some reason I can't attach the video((

2. This is known issue for regular multisig accounts, reproducible also here:

3. When I want to set name by default I will get an modal error, but name will be set after:

4. Is the text alignment correct here? it looks located close to the edges. @onvisions could you please help me here?

5. I found that QR is blinking in FFweb/ extension and it's hard to scan it from airgap vault:

https://github.com/superhero-com/superhero-wallet/assets/69896204/98d96155-b398-4a81-9002-9123c32c4a19

at the end qr code has been disappeared:

6. Also found some strange issues in console related to scan qr. Scan qr was not working for me in ff web and extension:

I see this issue also on prod in console (probably my local issue):

on dev branch FF ext from 05-Jun-2024 08:59 4917797 commit f8edee5:

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[Liubov-crypto]

Still reproducible for me:

1. QR scan isn't working in FF.
2. QR is blinking in FFweb/ extension (actually it's blinking in Chrome too, but I see that in FF delay in blinking is bigger) and it's hard to scan it from airgap vault and at the end qr code has been disappeared.
3. Sometimes when I want to create vault and choose 2 signer - Create multisig vault button will not respond to me in chrome extension (idk why, probably my pc is overloaded and heated):

https://github.com/superhero-com/superhero-wallet/assets/69896204/612dd0a0-14e7-4971-ab6f-31823b0af13b

4. do we changed design qr code here? it doesn't fit for the whole box:

@onvisions could you please confirm it?

5. This issue can be reproducible from time to time, especially when I'm proposing a Tx from vault with 0 balance: I've created multisig vault using airgap vault account as a first signer, after that I proposed a Tx from this superhero vault. I got an confirmation popup that Tx was successful but at the end no pending Tx in my sh wallet. Also I see that on the final step confirmation sign modal is missing if I compare it with multisig vault created from regular ae accounts.

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[Liubov-crypto]

I've created new wallet for testing.

ad 1. Fixed partly. Scan is working in web wallet but not working in FF extension.

ad 2. QR is blinking in FF:

ad 3. - not reproducible for me in new created wallet

ad 4. - updated and looks like it, but not in all places:

but please check all buttons in extension when created vault path and propose / revoke multisig tx:

ad 5. - not reproducible for me

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[Liubov-crypto]

Not a big issue, but when I want to propose multisig tx on some step there will be such qr:

as we agree ad 1 and ad2 will be resolved separately. The rest is LGTM.

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts

[github-actions[bot]]

Deployed to feat-airgap-integration.wallet.z52da5wt.xyz, artifacts