search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

perf: do not create new sdk instance on invite claim #3022

Closed CedrikNikita closed 6 months ago

CedrikNikita commented 6 months ago

fixes #1487

github-actions[bot] commented 6 months ago

Deployed to feature-do-not-create-new-sdk-instance-on-invite-claim.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 6 months ago

I can see my previous invite links in the wallet and can top up it.

I have a question, if I'm creating an invite link in testnet and after trying to claim it in new wallet, I'm getting a pop-up that gift card already claimed, but in fact it's not because I'm always login first in mainnet and then have to switch to testnet to claim invite link. Should we warn user about network discrepancy?

https://github.com/superhero-com/superhero-wallet/assets/69896204/1a90f5be-6464-4210-9c56-ad3c72e15494

CedrikNikita commented 6 months ago

I have a question, if I'm creating an invite link in testnet and after trying to claim it in new wallet, I'm getting a pop-up that gift card already claimed, but in fact it's not because I'm always login first in mainnet and then have to switch to testnet to claim invite link. Should we warn user about network discrepancy?

Invite links were invented mostly for mainnet. Feel free to open an issue about that, but I think such an addition would have very low priority.