search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Networks page items misalignment #3030

Closed onvisions closed 3 months ago

onvisions commented 6 months ago

Image

I suggest implementing shortening and the horizontal animation for displaying long URLs here. We have this feature ready and we use it at several places such as the dashboard Latest transactions widget.

peronczyk commented 3 months ago

We agreed with @onvisions that the URLs won't be scrolling. I updated the spacing between the node urls so now it's easier to read them.

Tsvetan requested to not apply the opacity change to action buttons (edit/remove) when the network is not activated (checked).

The task is ready to be reviewed @Liubov-crypto

Liubov-crypto commented 3 months ago

LGTM

onvisions commented 3 months ago

We agreed with @onvisions that the URLs won't be scrolling. I updated the spacing between the node urls so now it's easier to read them.

Tsvetan requested to not apply the opacity change to action buttons (edit/remove) when the network is not activated (checked).

The task is ready to be reviewed @Liubov-crypto

Yes, because even if radio button is not active the user can click on Edit/Delete and edit or remove Network. So the buttons are active and shouldn't look disabled.