search

superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

If I'm sending ETH and after ERC-20 tokens in Tx details on ETH page I will see ERC-20 instead of ETH #3079

Open Liubov-crypto opened 3 months ago

Liubov-crypto commented 3 months ago

Describe the bug If I'm sending ETH and after ERC-20 tokens in Tx details on ETH page I will see ERC-20 instead of ETH:

To Reproduce Steps to reproduce the behavior:

  1. Go to ETH acc
  2. Send ETH and then send ERC_20
  3. Go to ETH acc details, open first tx
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context reproducible on prod

https://github.com/superhero-com/superhero-wallet/assets/69896204/c61af073-2a1f-4ed0-bc8c-c8089f65b6a2

smaroudasunicorn commented 1 month ago

@Liubov-crypto may you check?

Liubov-crypto commented 1 month ago

@smaroudasunicorn it's reproducible for me on the dev branch.

I think the main reason behind it is that we have ERC-20 transaction in ETH account tx list because fee is paid in ETH and when I'm opening it to see the Tx details I will see ERC-20 transaction details which is correct. So, I propose to leave it as it is. What do you think @smaroudasunicorn @onvisions ?

https://github.com/user-attachments/assets/a994faa7-fb90-4aae-ac11-87df6bb7fbed

smaroudasunicorn commented 1 month ago

it seems ok to me. What is not clear to me is the following. In the description you say in 4. point see the error. From videos I could not spot any error.

Liubov-crypto commented 1 month ago

it seems ok to me. What is not clear to me is the following. In the description you say in 4. point see the error. From videos I could not spot any error.

I meant under "the error" that Tx is not displaying correctly to me. No error happens. It's just our standart text description which I haven't changed.

smaroudasunicorn commented 1 month ago

In transactions list, do not we show ERC-20 Token transaction and gas below? That should go in Ethereum account too, is not it? In Tx screen we should show ERC-20 transaction and show ETH in gas fees.

@Liubov-crypto @martinkaintas ?

Liubov-crypto commented 1 month ago

In transactions list, do not we show ERC-20 Token transaction and gas below? That should go in Ethereum account too, is not it? In Tx screen we should show ERC-20 transaction and show ETH in gas fees.

@Liubov-crypto @martinkaintas ?

In Tx list yes, but not in the ETH Coin details Tx list and the Latest Tx widget.