superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 42 forks source link

Show transaction and Tx details made on external dapps correct for user #3096

Open Liubov-crypto opened 2 weeks ago

Liubov-crypto commented 2 weeks ago

Describe the bug

I made swap from ETH to WETH, on confirmation modals it displays with tags: App.Uniswap.org and Contract call:

wi

when Tx will be completed and fetched I will see in Tx details this Tx as Spend Out:

eth2

I agree that user have to pay ETH for wrapping it to WETH as first part of Tx.

But we don't show the second part - incoming WETH to wallet balance in any way.... might be one confusion for user - WETH will be displayed on wallet balance, but incoming Tx related to this is not:

td

To Reproduce Steps to reproduce the behavior:

  1. Go to uniswap
  2. connect the wallet
  3. Swap ETH to WETH
  4. Check Tx details

Expected behavior We have to show to user Tx that he made as precise as possible.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.