search

superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 42 forks source link

Show approval modals within the wallet when user interacts with Dapps #3098

Closed Liubov-crypto closed 1 day ago

Liubov-crypto commented 2 weeks ago

Describe the bug This is not the bug rather or current implementation. But when I was testing uniswap I was observing that the modals were opening within the app. Should we implement such logic everywhere in wallet?

To Reproduce Steps to reproduce the behavior:

  1. Go to uniswap
  2. Click on connect wallet
  3. Made some Tx
  4. Observe where popups will be opened

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Liubov-crypto commented 1 day ago

Fixed within the wallet connect PR. Can be closed.