search

superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 42 forks source link

fix: remove window browser polyfill from ext background #3111

Closed peronczyk closed 1 week ago

peronczyk commented 1 week ago

This PR fixes 2 issues that happens in the chrome extension's background process.

  1. "window is not defined" - happening because we are including the polyfills for the browser which attempts to add the browser into window object, which does not exist in the background process. image

  2. "Only a single offscreen document may be created." - happening because we are running browser.runtime.getURL twice. image

github-actions[bot] commented 1 week ago

Deployed to fix-remove-window-browser-polyfill-from-ext-background.wallet.z52da5wt.xyz, artifacts

martinkaintas commented 1 week ago

Please also test this on FF as FF handles offscreen tabs different to chrome

Liubov-crypto commented 1 week ago

LGTM