search

superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

AENS - Remove Avatars mechanism (seeded images) since it does not offer any value. #3135

Closed smaroudasunicorn closed 2 months ago

smaroudasunicorn commented 3 months ago

This task is about removing these face-like avatar and replacing them with default geometrical ones:

Image

Also the name management page needs to be updated by totally removing the avatars placed next to the name entries:

Image

The pending indicator needs to be placed below the name:

Image

Liubov-crypto commented 2 months ago

I see that the images have been removed.

I have a few questions about the design, I compared to attached screens and see that there are some discrepancies. Was the design strictly implemented or is it in progress?

  1. When name is pending status it will be displayed without 3 dots.. Image

  2. If the name already has pointer it will be not visible under, only make default / default button is available:

https://github.com/superhero-com/superhero-wallet/assets/69896204/62effae3-3263-4bff-8bf4-4c32a47b549b

Image

  1. If I add as a pointer an account address that not belong to registered name I will be not able to set this name as default (it was possible before):

https://github.com/superhero-com/superhero-wallet/assets/69896204/5aaae557-6a70-4eed-8f95-b0cbb21e8f65

onvisions commented 2 months ago

@Liubov-crypto I have synced with @peronczyk the implementation of the design. I made two minor comments on my side:

About the design reference:

There is not updated design reference for the whole AENS feature in Figma. Meaning that the existing design is outdated. (For example we already have the Account details screen and the AENS design is still with the tabs placed directly below the account switcher instead in the Account details modal)

@smaroudasunicorn The reason for that is that we used to have on the roadmap Redesign of the whole AENS feature and there was no point in updating and then redesigning the whole thing. At the time PO decided we'd better focused on the redesign. However the AENS redesign was later postponed due to shift of priorities on the roadmap.

IMO I should spend couple of days on updating Figma design reference (AENS feature) to reflect current state of the extension/app.

Liubov-crypto commented 2 months ago

LGTM