superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

Further extend and improve address select inputs (related to Address Book feature) #3168

Open onvisions opened 3 months ago

onvisions commented 3 months ago

STORY:

  1. "As a user I would like to be able to easily choose one of my accounts as the recipient to simplify moving funds between own accounts."
  2. "As a user I would like to be able to select as Recipient one of the recent addresses I have sent assets to.
  3. As a user I'd like to be able to get a dropdown list of suggestions while typing recipient's name.

ACCEPTANCE CRITERIA:

Places to implement

Select recipient/signer modal is triggered by the book icon above recipient/signer inputs:

The Title of the modal in this case should be changed from "Select recipient's address" to "Select signer's address" (as the user is choosing an authorized signer for the multisig vault being created) and the word "recipient" should be updated to "signer" in all its occurrences.

Image

Image

..........................................................................

DESIGN:

Image

Bookmarked Image

Own Image

Address Book Image

Search results are displayed and filtering tabs are hidden. SearchResults-HideTabs

Recent Image

In case there are no bookmarked addresses in the Address book

Image

In case there are no address records for the currently active blockchain in the Address book:

Image

In case there are no transactions sent by the user to other recipients (for the active blockchain)

Image

..........................................................................

In case the modal is triggered from the Create new multisig vault modal (replace "recipient" with "signer"):

Image Image

FIGMA REFERENCE:

  1. https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=32250-196675&node-type=frame&t=0qFKMBlk9a6bxjM3-0

  2. https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=32267-206447&node-type=frame&t=0qFKMBlk9a6bxjM3-0

peronczyk commented 3 months ago

My initial idea was to have a one list of owned account addresses and the address book addresses: image

But this might be problematic with large lists of accounts. So maybe having tabs on this modal would be good idea? So user would be able to switch between "owned accounts" / "address book" / "recent recipients".

I'm not sure about the recent recipients. Maybe we should encourage users to use address book and make it easy to add the addresses they use into address book? For example if you send funds to a new address the app would suggest to add it to address book?

smaroudasunicorn commented 2 days ago

In transactions list if there is a known address book address display the address book record name instead of account 1, 2 etc.