search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

Don't refresh page after resetting the wallet #3307

Open peronczyk opened 2 weeks ago

peronczyk commented 2 weeks ago

If user resets the wallet the page should not be refreshed.

Initially refreshing the page was solving this issue found on mobile: https://github.com/superhero-com/superhero-wallet/pull/650#issue-749336687

This PR requires testing resetting the wallet only on web.

Liubov-crypto commented 2 weeks ago

LGTM

peronczyk commented 2 weeks ago

After talking with @CedrikNikita I decided to totally remove the action that refreshes the page for every environment (web/popup/mobile). Can you please retest this @Liubov-crypto but this time for every env? Nikita has concerns that without refreshing the page user could see some data from the previous accounts in his wallet when using new mnemonic. Can you please focus also on this?

Liubov-crypto commented 2 weeks ago

@peronczyk , @CedrikNikita is correct, I can see latest Tx from the previous account when I reset prev wallet and login with new account:

https://github.com/user-attachments/assets/c1400476-c4b4-470e-a8f6-bd832449687a

checked on web/ext/android app

peronczyk commented 2 weeks ago

Thanks @Liubov-crypto . I added a fix for this issue. Now resetting the wallet also wipes the transactions: Image

Can you retest please?

Liubov-crypto commented 1 week ago

Still reproducible for me:

https://github.com/user-attachments/assets/1cbda158-ff4d-4b24-a507-dcebdcb148e3

Image