search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Transaction Information - Set dollar sign to USD #3342

Closed smaroudasunicorn closed 4 weeks ago

smaroudasunicorn commented 1 month ago

We would like to improve the display of tx fee in dollars.

i.e.

Transaction fee 0.00001672 AE <$0.01

should rather be " < 0.000001 USD" (we need to calculate)

Change $ sign to USD, since $ is the original Peso sign which can be misleading for many people.

peronczyk commented 1 month ago

The PR is ready to be tested. One important thing is the order of the amount and the currency. We are using automatic currency formatting based on users language. American/GB english assumes that the currency name goes before the amount. This is why we need to display all the amounts as USD 123456.

Same as we do with AE on account cards: Image

Liubov-crypto commented 4 weeks ago

LGTM