superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Wallet Initialisation or Security Settings - Disable Set wallet Password #3347

Closed smaroudasunicorn closed 3 weeks ago

smaroudasunicorn commented 1 month ago

Story: User shall have the ability to skip set wallet password if he desires to undertake security risks.

Acceptance Criteria:

DESIGN:

Initialization of wallet (Skip password) Image

Image

REC: https://github.com/user-attachments/assets/9508af2b-28d8-4bf2-a9ff-0a8aaa1dd8b5

First time set password modal

Image

More/Settings/Secure login:

Image

Image

More (disabled state of Lock wallet button):

Image

Figma Reference:https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=33455-217248&node-type=frame&t=eELbU3K8u3GlJ8SW-0

smaroudasunicorn commented 4 weeks ago

I am ok

Liubov-crypto commented 4 weeks ago

During the testing I found some issues:

  1. It's not possible to skip set password on the first step, when creating/restoring a wallet. There is no skip password button. Also text is not updated according to Figma ref:

Image

  1. Set a password, I see some old text when click on "?"

Image

  1. Settings --> Secure login - some text discrepancies:

Image

  1. After I disabled a secure login, closed a wallet and back again, I was blocked by Enter password page. I entered my password, but system doesn't recognise it, however the password is correct:

https://github.com/user-attachments/assets/f2a4ea28-c71b-4c44-92aa-62212371239a

@peronczyk please check it

peronczyk commented 3 weeks ago

I have updated my PR with the fixes.

Ad 3. We agreed with @onvisions that we will have one common wording for this feature: "You will be asked to authenticate in order to unlock the wallet and continue using it."

Please retest @Liubov-crypto

Liubov-crypto commented 3 weeks ago

I found one difference on this screen: зф

but there is similar screen when I want to login wallet without such text, so I'm not sure, should that text be present or not? @onvisions could you please help me here?

the rest is fixed, LGTM

onvisions commented 3 weeks ago

@Liubov-crypto

  1. both variants are used. The first one is displayed when the user has the wallet installed and it has been updated to latest version that gives the option for setting password. https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=37194-305712&node-type=frame&t=sV4EHRVeZV3bAYCg-0

The second is when you are creating a new wallet or restoring one with seed phrase. https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=33514-212273&node-type=frame&t=sV4EHRVeZV3bAYCg-0

  1. Both variants should not have closing button for the modal: image
peronczyk commented 3 weeks ago

@onvisions OK I removed the close buttons. @Liubov-crypto is everything OK right now?

Liubov-crypto commented 3 weeks ago

LGTM