superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Transaction Details Improvements for tokens #3372

Open smaroudasunicorn opened 2 weeks ago

smaroudasunicorn commented 2 weeks ago

The following improvements are proposed for transaction details:\

  1. Provide a link to token name to navigate to token details page
  2. Display FIAT Value information as defined on the transaction date. (Same to be displayed on transaction List)
smaroudasunicorn commented 1 week ago

@onvisions can you help for this ticket too?

smaroudasunicorn commented 1 week ago

We can achieve it for token details without performance impact and additional complexity. Let 's proceed with that first

smaroudasunicorn commented 1 week ago

@CedrikNikita we would like to explore how to achieve to show historical data for every transaction. Following a sync with @paolomolo

onvisions commented 1 week ago

@smaroudasunicorn @CedrikNikita If we can follow the price history and draw a chart we can include such feature on the token details page. We can also think of user's portfolio showing the buys/sells and the average gains for specific token.

Regarding the scope of the current task I am suggesting the following as MVP:

1. Transaction details page:

Token sale: BUY

Token sale: SELL

DESIGN:

  1. Token Sale - Buy (price increased)

Image

  1. Token Sale - Buy (price decreased)

Image

  1. Token Sale - Sell (price increased)

Image

  1. Token Sale - Sell (price decreased)

Image

FIGMA REFERENCE: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=37558-322970&node-type=frame&t=AZN7JJF0uYJ7uRwk-0

2. Transactions list: (we keep it as it is) Token sale: BUY

Image

Token sale: SELL

Image

All fiat values should be always calculated based on the price of the asset compared to fiat at the present moment.

onvisions commented 1 week ago

DESIGN V2 @smaroudasunicorn In this suggestion we track the price of the ADASTRA token against AE coin and USD (fiat) at the moment of BUY/SELL and at the current moment; The change of price is also displayed in %:

  1. BUY

Image

  1. SELL

Image