search

superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

Use modal to display permission add/edit page. #3390

Closed peronczyk closed 4 days ago

peronczyk commented 2 weeks ago

This task was created as a follow up to this conversation: https://matrix.to/#/!RkOrOMUKQQwsmfYARY:superhero.com/$SSQ81mTIGywrSIalkP7xq0xrO2GV_HisuIGIJ117x7g?via=superhero.com

This task needs approval by @smaroudas and @onvisions .

peronczyk commented 1 week ago

@smaroudasunicorn , @onvisions - what do you think about this change?

@Liubov-crypto this is ready to be tested.

Liubov-crypto commented 1 week ago

@peronczyk if this pr is only about Permission page then, LGTM. Image

I haven't found any changes on Address book or Network following conversation that you attached. Please confirm if it's only related to permission add/edit page.

If there are any changes to design please attach link to Figma.

onvisions commented 1 week ago

@peronczyk I agree to use this approach for "Add permissions" and "Add address". I don't think you need specific design to make this change. However I can't give the final approval for implementation. @Liubov-crypto At the moment I have focused on higher priority tasks so I'll update the Figma reference later. The only change here is about transforming page into a modal so visually the header part will be changed - back arrow removed, X close button will be closing the modal and the bottom buttons should be fixed to bottom.

smaroudasunicorn commented 4 days ago

I am ok too