search

superhi / editor-issues

A place to report issues on the SuperHi Editor
4 stars 0 forks source link

Full preview not updating #9

Closed kdholland closed 5 years ago

kdholland commented 5 years ago

Hey @artcommacode ! Have noticed this one a few times and finally getting around to reporting it - let me know if you've got any questions.

Describe the bug The full preview isn't staying up to date with code changes.

To Reproduce Steps to reproduce the behaviour:

  1. Work on some code changes in the code/split screen view
  2. Click on Preview icon in the sidebar
  3. Code changes aren't reflected in full preview
  4. Click refresh icon at the bottom - code changes still don't show up

Expected behaviour Full preview should be up to date, or update after clicking refresh icon.

Screenshots

Code view with split screen preview - code is up to date: image

After clicking on Preview icon - code isn't updated: image

Device (please complete the following information):

kdholland commented 5 years ago

just a note that refreshing the browser seems to do the trick, but clicking the refresh icon in the bottom bar does not.

artcommacode commented 5 years ago

Ahh yes the full-page Preview hasn't been yet been touched in the new Editor so is currently relying on some old code that has since been trimmed!

artcommacode commented 5 years ago

Fixed in https://github.com/superhi/editor/commit/6ed1ad56c8cb4e6bfc28934b8d61942facd92af8, we now have manual reloading in the full-screen preview again.

kdholland commented 5 years ago

Yep, manual reloading looks good - thanks @artcommacode !