superhighfives / pika

An open-source colour picker app for macOS
https://superhighfives.com/pika
MIT License
1.71k stars 55 forks source link

Pika icon shows on top of Apple menu after restart when set to "Hide menu bar icon" #108

Closed bikrrr closed 9 months ago

bikrrr commented 11 months ago

Describe the bug Restarting Pika or macOS will result in the Pika menu bar icon displaying on top of the Apple menu icon in the upper-left corner of the display.

To Reproduce Prerequisites: Launch at login: Enabled Hide menu bar icon: Enabled App Settings: Menu bar

Steps to reproduce the behavior:

  1. Restart macOS -OR- quit & restart Pika
  2. View the left side of the menu bar

Expected behavior No Pika menu bar icon would be visible.

Screenshots Pika Menu Bar Icon Visible

Pika Settings For Repro

Environment (please complete the following information):

Additional context I actually saw a variation of this on Ventura, where the icon would display further down the display's left edge, but it was sporadic so I never logged it.

bikrrr commented 11 months ago

I should add that toggling Hide menu bar icon off and on again in Pika Preferences, will fix it until the next restart.

jhil commented 11 months ago

Thanks! I also have this issue. Also, sometimes it shows up about halfway down my screen (but still on the far left edge). Let me know if I can help with more repro details.

Screenshot 2023-10-01 at 16 30 26

superhighfives commented 11 months ago

Finally getting around to taking a look at this bug, and I'm struggling to reproduce it. Out of curiosity, which laptop are you using? Does it have a notch? Thanks so much for reporting!

bikrrr commented 11 months ago

Hey, Charlie!

I'm seeing it on a 2021 14" MacBook Pro (has a notch) on Sonoma 14.0 (23A344). It happens both on the MacBook display and when extended to an Apple Studio Display, even with the laptop in clamshell mode (closed).

jhil commented 11 months ago

Apple M1 Max, 14 inch with notch, macos 14.0 (23A344)

3x3cut0r commented 11 months ago

MacMini M2, external monitor with of course no notch. macos 14.0.

aguilaair commented 10 months ago

M1 MBP 2021 16" on Sonoma 14.1 Beta (23B5067a)

Sydnxt commented 10 months ago

M2 MAX MBP 2023 16" on Sonoma 14.1 Beta (23B5067a)

nidhin-locale commented 10 months ago

I have the same issue, except mine refuse to go away even set it to show on dock. Using 2020 m1 macbook air, with macos 14.0

Screenshot 2023-10-25 at 22 42 24
nidhin-locale commented 10 months ago

It is possible to move the icon from the top left with "cmd + drag", but does not snap with other icons on the menu bar.

Uploading Screen Recording 2023-10-31 at 16.49.09.mp4…

superhighfives commented 10 months ago

Really struggling to recreate this one consistently, but still looking into it. Thanks for all the context, and if there are any specific steps that consistently recreate the issue, please let me know. Also @nidhin-locale, it looks like the video you share didn't upload successfully.

bikrrr commented 10 months ago

@superhighfives I just submitted a pull request, which (I think) fixes the issue. I tested it on both an Apple Silicon and Intel Macs and worked properly on both (no more errant Pika menubar icons).

This is my first pull request so hopefully, I did it right?! 🤞😅

superhighfives commented 9 months ago

Awesome, perfect PR @bikrrr—really appreciate it! 😊 Aiming to release a beta for this and Spanish localisation this week.

bikrrr commented 9 months ago

Cool. Since you're working on localization, do you plan to update the Preferences... menu item to Settings... to match macOS's latest standard (link)? And possibly add command comma (⌘+,) as the shortcut (link)?

If not, that's okay. I wouldn't mind trying another PR…I could use the practice! :)

superhighfives commented 9 months ago

Ah, good catch, @bikrrr! I can definitely make that change as part of 0.0.16, but if you'd like to take a pass at the PR for practice you're more than welcome. Let me know what you'd prefer.

bikrrr commented 9 months ago

Why don't you make the change?

I still have a lot to do on a personal project. Maybe in a while when I need a change of scenery, I can try my hand at another Pika issue!

superhighfives commented 9 months ago

Awesome, sounds good @bikrrr. Will do. 👍

superhighfives commented 9 months ago

This is now released as 0.0.16-beta1, which you can access by downloading it from https://github.com/superhighfives/pika/releases/tag/0.0.16-beta1, or by checking "Subscribe to beta releases" in Pika's settings and then "Check for updates..." in the menu. Thanks @bikrrr, ya superhero!

Any feedback or issues, please let me know.