Fix for errant menubar icon (#108): Added check if window canBecomeKey before making it key

superhighfives / pika

An open-source colour picker app for macOS

https://superhighfives.com/pika

MIT License

1.71k stars 55 forks source link

Fix for errant menubar icon (#108): Added check if window canBecomeKey before making it key #111

Closed bikrrr closed 9 months ago

bikrrr commented 10 months ago

This avoids the error when making statusBarItem key, since it's an NSStatusItem and can't become key. This fixes issue #108 - Pika icon shows on top of Apple menu after restart when set to "Hide menu bar icon".

superhighfives commented 9 months ago

Awesome! Thanks for making this PR. Will test and add to 0.0.16. 👍

superhighfives commented 9 months ago

This is now released as 0.0.16-beta1, which you can access by downloading it from https://github.com/superhighfives/pika/releases/tag/0.0.16-beta1, or by checking "Subscribe to beta releases" in Pika's settings and then "Check for updates..." in the menu. Thanks @bikrrr, ya superhero!

Any feedback or issues, please let me know.