superhighfives / pika

An open-source colour picker app for macOS
https://superhighfives.com/pika
MIT License
1.77k stars 58 forks source link

WCAG AA normal size shown (rather than AA large) #80

Closed joeledge closed 2 years ago

joeledge commented 2 years ago

Is your feature request related to a problem? Please describe. Most often I need to check WCAG contrast for text at normal size, Pika only shows AA Large

Describe the solution you'd like Show WCAG compliance for AA normal size rather than just large

Describe alternatives you've considered Preferences to allow what is show in the bottom WCAG Compliance area to be customised

superhighfives commented 2 years ago

Hey @joeledge—thanks for taking the time to open an issue. AA normal is included, but it might not be immediately clear. The scale is AA Large, then AA Normal or AAA Large, then AAA:

image

The AA Normal is the first two letters of the center item in the WCAG Compliance section.

One thought—maybe having it as AA / AAA Large, or AA or AA Large would make it clearer. 🤔

image image

Using a / would be easier for translation.

joeledge commented 2 years ago

Thanks for responding! I could definitely use knowing that, personally I find it a little confusing as am used to seeing 'Normal' or 'Large' so I don't think I'd assume that without knowing prior it was for normal.

Perhaps something like this? (I'm not sure if complicated to implement from a dev point of view though!)

Screenshot 2022-05-19 at 14 34 34
superhighfives commented 2 years ago

No worries at all, and appreciate the suggestions. Been noodling on it a little on this PR, @joeledge.

Maybe it's preference? Will have a think about how it might translate to touch bar, too.

superhighfives commented 2 years ago

Sweeeeeet—got a new beta for you to check out, @joeledge. Added it as an appearance preference in the preferences, and defaulted to the new style as I agree it's easier to understand at a glance. Let me know what you think (to check out a beta, download it from here, or enable betas in Preferences and click "Check for updates" in the menu.

Pika v0.0.13-beta app screenshot
joeledge commented 2 years ago

Awesome, that works brilliantly for me. Thanks for taking the time to work on this issue!

Screenshot 2022-06-06 at 09 07 28

.