superhighfives / pika

An open-source colour picker app for macOS
https://superhighfives.com/pika
MIT License
1.71k stars 55 forks source link

Pika icon displays when connecting to an external display #99

Closed gitatmax closed 8 months ago

gitatmax commented 1 year ago

Describe the bug When using an external display, even with the Pika toolbar icon disabled, the icon will sometimes appear to the left of the external monitor until the app is force-quit & re-opened

To Reproduce

  1. Disable the toolbar icon
  2. Connect to an external display
  3. The icon should appear after some time or a restart

Expected behavior The icon shouldn't ever appear anywhere

Screenshots I will grab a screenshot to post here when I see it next.

Environment (please complete the following information):

superhighfives commented 1 year ago

Ugh, that's not great. It sounds like a bug in macOS, given that the current implementation is using .isVisible to show and hide it.

I can try and recreate it, but is there anything you've noticed that might be triggering it? For example, plugging into or disconnecting the external display? There may be an event I can hook into to ensure it's reflecting the right visibility.

Thanks for flagging, too, @gitatmax. 👍

jacob-shuman commented 1 year ago

I'm having the same issue as well, I believe the issue may be caused when connecting to an external display. Not sure if it's relevant but I have 2 external monitors connected and it looks like it's showing on the monitor on the left which happens to be the primary display.

I am using macos ventura 13.3.1

Please let me know if theres anything else i can help with!

(I love Pika, thank you so much for all the time and effort that goes into working on it)

Screenshot 2023-06-01 at 2 16 17 pm

superhighfives commented 1 year ago

Thanks for sharing the additional context, @jacob-shuman, and for the kind words.

Out of curiousity, does this happen with any other apps you're using?

jacob-shuman commented 1 year ago

Thanks for sharing the additional context, @jacob-shuman, and for the kind words.

Out of curiousity, does this happen with any other apps you're using?

Not that I've noticed no. I've only ever see it happen with Pika in recent memory.

arthurflor23 commented 1 year ago

Hi,

Same problem here. It happens when I connect closed mac to an external monitor, and the temporary solution is to completely close and reopen the app. Also, it only happens with the Pika app in "Hide menu bar icon" checked.

jhil commented 11 months ago

Another repro here, sharing my comment from another issue: https://github.com/superhighfives/pika/issues/108#issuecomment-1742223111

superhighfives commented 11 months ago

Thanks for all the feedback on this one, everyone. Added to my milestone for the 0.0.16 release, which I'm planning on getting started on (along with #109, etc).

superhighfives commented 11 months ago

Finally getting around to taking a look at this bug, and I'm struggling to reproduce it. Out of curiosity, which laptop are you using? Does it have a notch? Thanks so much for reporting!

scherii commented 11 months ago

Hi @superhighfives You might be on to something! 😄 I am using a Notch MacBook Air and did not have this problem on my iMac before, even though the same screens were connected.

superhighfives commented 11 months ago

Hmmm, okay! Will dust out an older MacBook Pro and give that a shot. Thanks @scherii!

superhighfives commented 11 months ago

Whoa, plot twist, happened on my external display (with a notch-y MB).

Screenshot 2023-10-11 at 17 20 31

Now to work out what on earth is going on there. 😅

bikrrr commented 9 months ago

Oops! I must have missed this before submitting issue #108, as it seems to be the same problem. The latest update should fix it.

Can everyone here update to Pika 0.0.16 and report back if it's still an issue?

jacob-shuman commented 8 months ago

Finally getting around to taking a look at this bug, and I'm struggling to reproduce it. Out of curiosity, which laptop are you using? Does it have a notch? Thanks so much for reporting!

I haven't updated to the latest version yet but I can confirm this was happening on my 2019 macbook pro (connected to 2 external monitors) without a notch.

bikrrr commented 8 months ago

@jacob-shuman Please let us know if it still happens for you with 0.0.16. Thanks! 🙏

jacob-shuman commented 8 months ago

Looks like 0.0.16 fixed it for me 🚀

this is what I tried:

Thank you for the fix, I really appreciate the work that went into getting this resolved!

bikrrr commented 8 months ago

Sure thing! Glad to hear it's now working for you. 🙌

superhighfives commented 8 months ago

All credit goes to @bikrrr for his awesome work on this. Thank you! 😊

superhighfives commented 8 months ago

Going to close this one now. 🥳