Open JonathanLindsey opened 1 year ago
Here's an incomplete list of some more ways to continue moving things into submodule classes. It's possible something I say doesn't work out. Please keep me posted.
Drive.driveInit()
and Drive.NavXInit()
private methods and call them from the Drive constructor method.pickerUpper.grabber.periodicGrabber();
and pickerUpper.arm.updatePosition();
are run in robotPeriodic()
. They should be moved to a PickerUpper.periodic()
method that gets called by robotPeriodic()
.robotPeriodic()
is pit safety/pit override and LED code. The LED for loop code for setting the LEDs is repetitive and should be refactored into a method in the Leds class. Pit safety/pit override code should be moved to the Tower class.Here's what I'm thinking, let me know if this doesn't make since.
Please use the checkboxes above as you commit and push.
Grabber.holdAuto()
method that sets the grabber to -0.3? Couldn't we use the close()
method that sets the grabber to -grabberSpeed
(which is currently 0.7)?Grabber.hold()
method that sets the grabber to 0 feels misnamed; relax()
would make more sense to me.Grabber.closeCube()
isn't used and does nothing so should be deleted.
This is in part preparation for a move to command based.
For now Joystick code should stay in
Robot.java
and not get moved to the submodule.If you want to move the submodule classes to their own folder, that should just be a separate commit in order to keep the commit diffs nice.