search

superjohan / ifm

Intergalactic FM for iPhone
1 stars 2 forks source link

graphic changes #2

Closed alepar666 closed 3 years ago

alepar666 commented 3 years ago

pretty simple modifications, updated the channels graphic with current website's and dynamic text color / font mocked play button inside banner note: graphics for now are manually made by me, they could be replaced with better ones arriving later in time, but the structure could be this one. regarding the scrolling text, do you think there is a need to change the current coordinate positioning method (the one in the comments is mentioned as FIXME) I tested with different iphone version simulator and indeed there is some slight difference... that could be really something to fix.

alepar666 commented 3 years ago

New graphics, custom font for scrolling text, official json file hosted on IFM for radio channels url and api for getting "playing now" info.

superjohan commented 3 years ago

I did a rebase which apparently totally fucked up this PR. Sorry. I'll open up a new one. For future reference, never use the main branch for pull requests. :)

alepar666 commented 3 years ago

No worries, I am so worst than you ! Just to be sure you’re aligned with the latest graphics and code, I have all in my master branch, If I need something to do in order to allow you to get that let me know, otherwise you can start directly from that instead of the “update” branches...

Il giorno 13 gen 2021, alle ore 19:27, Johan Halin notifications@github.com ha scritto:

I did a rebase which apparently totally fucked up this PR. Sorry. I'll open up a new one. For future reference, never use the main branch for pull requests. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/superjohan/ifm/pull/2#issuecomment-759634548, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASH55PBQVRXUSEKKJTRU2UTSZXQXXANCNFSM4VJ4H4MQ.

superjohan commented 3 years ago

I merged the first PR. Opened a new PR with the changes from this one: https://github.com/superjohan/ifm/pull/3

I had some conflicts, hope I didn't fuck everything up.