search

superjohan / ifm

Intergalactic FM for iPhone
1 stars 2 forks source link

Extract the audio player to its own class #24

Closed superjohan closed 10 months ago

superjohan commented 10 months ago

The player is now written in Swift. This is done in anticipation of CarPlay support, which will require exactly this if we want it to work properly. I also reworked the UI code quite extensively. It is now much simpler and straightforward. There may be some bugs I haven't run into yet, though.

MainViewController is so small now that it could also be rewritten in Swift, although I'd rather do that in a separate PR. It would make IFMPlayer a bit more ergonomic to use, since we could use associated types in enums and all that jazz.

Would either @alepar666 or @tijmenb be interested in reviewing/testing this?

tijmenb commented 10 months ago

Great! Will take a look at this tonight!

superjohan commented 10 months ago

Great! I'll merge this and prepare a release shortly. I started working on converting the view controller to Swift as well, with all that entails, but I'm not sure it'll make it just yet. Just that the ObjC stuff in the player bothers me now. :)