superkaiba / pe

0 stars 0 forks source link

Confusing error message when use wrong format for "new" command #1

Open superkaiba opened 1 year ago

superkaiba commented 1 year ago

If the desired format for the "new" command is not followed, (i.e. new [o/OPTION] SECRET_NAME [f/FOLDER_NAME]) then the error message given is Illegal Secret Name: Please use only alphanumeric numbers and '_' when the real source of the error is that the format for the "new" command is not followed.

Steps to reproduce:

Screenshot: image.png

nus-se-script commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Here, the program does not make the assumption that the format is wrong. it assumes the user tries to give an input for the secret name that includes a ' ' and '/' character in the secret name. In reality, there is no real way for the program to tell the difference, because in our program only the "o/", "c/" and "f/" are assumed to parts of any command. This was designed to minimise restrictions for users but still allow data to be easily written and retrievable/ findable.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]