search

superkaiba / pe

0 stars 0 forks source link

Error message for illegal secret name is inaccurate and confusing #2

Open superkaiba opened 1 year ago

superkaiba commented 1 year ago

If a secret name containing non alphanumeric characters is input into the "new" command, the given error message is Illegal Secret Name: Please use only alphanumeric numbers and '_'. However, this error message should read "alphanumeric characters" instead of "alphanumeric numbers", because the latter doesn't make sense and is somewhat confusing

Steps to reproduce:

image.png

soc-pe-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message for illegal folder name is inaccurate and confusing

If a folder name containing non alphanumeric characters is input into the "new" command, the given error message is Illegal Secret Name: Please use only alphanumeric numbers and '_'. However, this error message should read "alphanumeric characters" instead of "alphanumeric numbers", because the latter doesn't make sense and is somewhat confusing

Steps to reproduce:

  • Input the command new o/StudentID test f/test^

Screenshot:

image.png

[original: nus-cs2113-AY2223S2/pe-interim#2525] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is not really a feature flaw (as describe by tester), but a small bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]