"new o/CreditCard" command accepts expiration date in the past

[superkaiba]

When using the "new o/CreditCard" command, the application allows the user to input an expiration date which has already past (or is too far into the future to be possible). I believe this is inconsistent with some of the other behaviour of the application. For instance, the application verifies that the credit card number and CVC are in the correct format so why should it not verify that the expiration date is possible.

Steps to reproduce:

• Input the following sequence of commands:

[nus-pe-script]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

As a Feature, some users may opt to save their older, expired credit cards. Different banks have also different terms of Credit Card Expiry date timeline (5 years, 4 years, etc). Since we want to be inclusive to everyone, we do not restrict these.

For these reasons, we kept it as such in this iteration. But we may improve the checking and even reminding for expiry dates in future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [ ] I disagree

Reason for disagreement: [replace this with your reason]

---

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]

---

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]

---